[Kde-imaging] libkipi 0.1: srcdir != builddir bug outside keg-libs-1

[Achim Bohnet]

On Friday 22 October 2004 04:56, Renchi Raju wrote:
> 
> On Tue, 19 Oct 2004, Achim Bohnet wrote:
> 
> >
> > building libkipi in a (minimal) pbuilder chroot environment
> > without libkipi installed breaks with:
> >
> > I never found this before because cvsExtract (?) seem to strip one libkipi
> > level from the keg-libs-1 layout, but cvs2dist I used earlier does not :(
> >
> >  keg-libs-1/libkipi/libkipi/interface.h
> > but
> >  libkipi-0.1/libkipi/interface.h
> >
> > My hack below supports both layouts:
> >
> > --- libkipi-0.1.orig/libkipi/Makefile.am
> > +++ libkipi-0.1/libkipi/Makefile.am
> > @@ -1,5 +1,5 @@
> >  METASOURCES = AUTO
> > -INCLUDES=  -I$(top_srcdir)/libkipi $(all_includes)
> > +INCLUDES=  -I$(srcdir)/.. $(all_includes)
> >
> >  KDE_ICON = kipi
> >
> >
> > don't know it there's a more elegant solution that '..' usage
> > (beside using cvs2dist ;).
> 
> hmm... i had to struggle with libkipi a little bit, when i used
> cvsExtract.sh . it messed up the directory layout and could generate the
> pkg-config file correctly. There have been no significant changes in the
> library. is the above issue enough to warrant a 0.1.1 release. i'm ok with
> that.

If there is no plan to enhance/extend libkipi in the 'near' future I would
suggest to make a new release together with kipi-plugins.  AFAIU as long as
header do not change there no risk of breakage.

Because noone else complained yet, there's to need for hurry.
Builddir!=srcdir seems not very commenly used (at least for first
time installations) ;)

Achim
> 
> renchi
> _______________________________________________
> Kde-imaging mailing list
> Kde-imaging at kde.org
> https://mail.kde.org/mailman/listinfo/kde-imaging
> 
> 
> 

-- 
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- reddy at lion.austin.ibm.com