[Kde-imaging] Naming inconsistencies

[Aurelien Gateau]

Le samedi 29 Mai 2004 10:32, Jesper K. Pedersen a écrit :
> On Saturday 29 May 2004 00:00, Aurelien Gateau wrote:
> | Hello,
> |
> | Today I was looking at our current API and spotted a few inconsistencies
> | in the names we are using.
> |
> | * Album vs ImageCollection
> | Our image container class is named ImageCollection, but we have some
> | various parts where we're speaking about Album. I think we should rename
> | ImageCollection to Album. This means the following changes:
> |
> | ImageCollection -> Album
> | ImageCollectionShared -> AlbumShared
> |
> | And also in the Interface class:
> | - currentAlbum -> currentView
>
> I strongly disagree on this. If you want to clear those things it should be
> the other way. I'd say it does little sense to return an Album when asking
> for the selection for example.
I see your point, but what is returned by the currentSelection() method is 
indeed an instance of ImageCollection, with a name and a comment. I would say 
this does little sense too.

I agree the "Album" word does not conceptually match KimDaBa image 
collections, but it just seems to be the word which springs naturally in 
head, at least much more naturally than ImageCollection. Just look at the 
amount of code we wrote using the Album word. It's also much easier to type. 

Maybe we would just need to explain in the doc that the albums might be 
"virtual" depending on the way the host app works.

Aurélien