[Kde-imaging] Selecting images for plugins

[Renchi Raju]

On Mon, 28 Jun 2004, Aurélien Gâteau wrote:

> Le jeudi 24 Juin 2004 18:00, Jesper K. Pedersen a écrit :
>
> > May I conclude that you state that what we currently have is just fine
> > (modulo the currentScope)?
> > If so, then I agree with you, personally I have no need for changing things
> > as they are now.
> >
> > Could we agree on the currentScope() function being virtual, so KimDaBa
> > could reimplement it to its current value, with the default being to return
> > the selection?
> > Still keeping currentSelection and currentAlbum in case som plugin wanted
> > to do something specific.
>
> As far as I'm concerned, I think the current* methods are ok. Plugins which
> modify the images should use currentSelection() only, plugins which only read
> images should use either one of the three methods.
> I don't see a need for it being virtual now, but it should not imply any
> performance cost, so I'm ok to have it virtual if you need.

i'm still not convinced that currentScope is needed as it seems to be a
convenience function which is an aggregate of the other two current*
methods. at the plugin end one can easily replace a currentScope call with
calls to other two selection methods. but, having said that, if the
currentScope method always behaves as its doing currently (i.e. return
currentSelection if there is a selection and return currentAlbum if there
is no selection), then i'm ok with it being included.

another thought, maybe the names could be changed to currentSelectedItems
and currentAllItems, as the currentAlbum tends to be slightly confusing
(for the kimbdaba case especially as currentAlbum may or may not be a part
of allAlbums)

renchi