i18n breaks KStars build

Sat Dec 9 14:20:37 GMT 2023

Albert wrote:

> The update of the docbooks is manual and whoever updates them has to check
> they commit a compiling doc, and i'm relatively sure our scripts do it
> correctly, so i'd like to know the workflow that Freek uses because he's
> either using some custom scripts that don't do this correctly or our scripts
> need improving.

When I ran `l10n-scripty/update_xml --nodelete nl kstars`, I got:

[...]
po2xml documentation/kstars/kstars/index.docbook nl/docmessages/kstars/kstars.po
A         nl/docs/kstars/kstars/index.docbook
index.docbook:422: element link: validity error : Element link does
not carry attribute linkend
&commands;    <!--Command Reference-->
         ^
warning: failed to load external entity "ekos-capture.docbook"
warning: failed to load external entity "ekos-focus.docbook"
index.docbook:289: element link: validity error : IDREF attribute
linkend references an unknown ID "ekos-capture"
index.docbook:137: element link: validity error : IDREF attribute
linkend references an unknown ID "ekos-capture"
index.docbook:348: element link: validity error : IDREF attribute
linkend references an unknown ID "ekos-capture"
index.docbook:630: element link: validity error : IDREF attribute
linkend references an unknown ID "ekos-focus"
kf.doctools.core: Error: `xmllint --noout` outputted text

What I find confusing are the line numbers given:
index.docbook:422  points to the &commands;    
but that is not helpful, we are not told what the actual offending line is.
The line numbers for the link validity errors (289,137,348,630) do not
make sense for index.docbook.

On the other hand,
$ egrep 'linkend="ekos-(capture|focus)"' nl/docs/kstars/kstars/*.docbook
nl/docs/kstars/kstars/ekos-guide.docbook:288:> selecteren. Standaard
moet Ekos het volgvakje tot aan 3 pixels toe ditheren (&ie;
verplaatsen) na N frame die
in de <link linkend="ekos-capture"
nl/docs/kstars/kstars/ekos-scheduler.docbook:136:>bestand: Het
sequentiebestand wordt samengesteld in de<link linkend="ekos-capture"
nl/docs/kstars/kstars/ekos-scheduler.docbook:347:>Lees het rijbestand
in in de <link linkend="ekos-capture"
nl/docs/kstars/kstars/fitsviewer.docbook:629:>In de <link linkend="ekos-focus"

Perhaps those line numbers can help.

-Oliver

On Sat, Dec 9, 2023 at 12:38 PM Albert Astals Cid <aacid at kde.org> wrote:
>
> El dissabte, 9 de desembre de 2023, a les 10:04:57 (CET), Johnny Jazeix va
> escriure:
> > Hi,
> > This is how I understand it, correct me if wrong:
> > The source files have been updated a few days ago:
> > https://invent.kde.org/education/kstars/-/commit/d694512d85b334287b832ab3609
> > a20f76f6ec724. The changes affects the links names.
> > As the translation is not yet updated, the po files inside the git
> > repository still have the old links.
> > When the compilation of the docbook happens, it still have the old files
> > and it complains it does not find the correspondance with the new links so
> > there is an error.
>
> This is only partially correct, the problem is that someone run a docbook
> update and only updated half of the docbooks, so they ended up in an
> inconsistent state.
>
> That is, we don't force translated docbooks to be in sync with the english
> text, they can be decades old (that's a separate issue).
>
> The update of the docbooks is manual and whoever updates them has to check
> they commit a compiling doc, and i'm relatively sure our scripts do it
> correctly, so i'd like to know the workflow that Freek uses because he's
> either using some custom scripts that don't do this correctly or our scripts
> need improving.
>
> Cheers,
>   Albert
>
> >
> > The solution is to remove the failing index.docbook files for now until the
> > translation is 100% and it will be generated again.
> >
> > Cheers,
> > Johnny
> >
> > Le sam. 9 déc. 2023 à 09:49, Oliver Kellogg <olivermkellogg at gmail.com> a
> >
> > écrit :
> > > It seems that l10n-scripty/update_xml is unforgiving about less than
> > > 100% translated po files,
> > > it prints
> > >
> > > [...]
> > > po2xml documentation/kstars/kstars/ekos-analyze.docbook
> > > nl/docmessages/kstars/kstars_ekos-analyze.po
> > > nl/docmessages/kstars/kstars_ekos-capture.po: 132 translated messages,
> > > 40 untranslated messages.
> > > nl/docmessages/kstars/kstars_ekos-focus.po: 465 translated messages,
> > > 50 untranslated messages.
> > >
> > > and skips the files for which it prints the statistics, i.e.
> > >
> > >     kstars_ekos-capture.po and kstars_ekos-focus.po
> > >
> > > which later on appears to make problems.
> > >
> > > What I find strange is that the problem surfaces only now.
> > > Those files were less than 100% translated already since Nov 29.
> > >
> > > -Oliver
> > >
> > > On Sat, Dec 9, 2023 at 12:59 AM Hy Murveit <murveit at gmail.com> wrote:
> > > > i18n--Please check this build error:
> > > >
> > > > https://invent.kde.org/education/kstars/-/jobs/1427868
> > > >
> > > > Thanks,
> > > > Hy
> > > >
> > > > On Tue, Aug 8, 2023 at 10:51 PM Jasem Mutlaq <mutlaqja at ikarustech.com>
> > >
> > > wrote:
> > > >> Hello,
> > > >>
> > > >> Build log: https://invent.kde.org/education/kstars/-/jobs/1107308
> > > >>
> > > >> Can you please check?
> > > >>
> > > >> --
> > > >> Best Regards,
> > > >> Jasem Mutlaq
>
>
>
>