Review Request 130115: skip the disabled backlight device

Lamarque Souza lamarque at kde.org
Fri May 5 13:49:31 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130115/#review103191
-----------------------------------------------------------


Ship it!




Ship It!

- Lamarque Souza


On May 5, 2017, 1:16 p.m., AceLan Kao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130115/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 1:16 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> While adjusting the brightness, if there are more than one graphics card
> on the machine, then there might be more than one backlight interface
> directories under /sys/backlight. Only one of them is active, and in the
> code, KDE picks the first one in the list as the backlight device. It
> might pick the wrong one if the active device is the second one.
> So, we try skipping the disabled one and can fix the brightness issue on
> some machines with more than one graphics cards.
> 
> Signed-off-by: AceLan Kao <acelan at acelan.idv.tw>
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/backlighthelper.cpp fb5f7ed991c320b242224930e0109d03cb328a6f 
> 
> Diff: https://git.reviewboard.kde.org/r/130115/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> AceLan Kao
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20170505/85898732/attachment.html>


More information about the Kde-hardware-devel mailing list