Review Request 129293: Add a CMake option to switch between HAL and UDisks managers on FreeBSD.

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129293/#review100432
-----------------------------------------------------------




src/solid/devices/CMakeLists.txt (line 97)
<https://git.reviewboard.kde.org/r/129293/#comment67401>

    Add "if (CMAKE_SYSTEM_NAME MATCHES FreeBSD)" since this change is FreeBSD specific. This option does not make sense in Linux for instance.



src/solid/devices/CMakeLists.txt (line 117)
<https://git.reviewboard.kde.org/r/129293/#comment67403>

    Your patch still compiles hal even though it will not be used.


- Lamarque Souza


On Oct. 31, 2016, 11:25 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129293/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 11:25 a.m.)
> 
> 
> Review request for Solid and Tobias Berner.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> While these backends can coexist, this would result in duplicated device entries in Solid for a single real device.
> 
> 
> Diffs
> -----
> 
>   src/solid/devices/CMakeLists.txt d51ebb3 
>   src/solid/devices/config-solid.h.cmake a68af32 
>   src/solid/devices/managerbase.cpp eee4de5 
> 
> Diff: https://git.reviewboard.kde.org/r/129293/diff/
> 
> 
> Testing
> -------
> 
> Compile.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20161031/007ebc1e/attachment.html>