Review Request 129277: Use built-in QByteArrayList type instead of our own.
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Oct 28 22:27:51 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129277/#review100374
-----------------------------------------------------------
Fix it, then Ship it!
src/solid/devices/backends/udisks2/udisksmanager.cpp (line 51)
<https://git.reviewboard.kde.org/r/129277/#comment67368>
Remove
+1 makes sense
- Aleix Pol Gonzalez
On Oct. 28, 2016, 6:59 p.m., Gleb Popov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129277/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2016, 6:59 p.m.)
>
>
> Review request for Solid.
>
>
> Repository: solid
>
>
> Description
> -------
>
> This patch replaces uses of `typedef QList<QByteArray> ByteArrayList;` with built-in `QByteArrayList` type. This type was in Qt since 5.4, while Solid requires 5.5.
>
>
> Diffs
> -----
>
> src/solid/devices/backends/udisks2/udisks2.h 0abf915
> src/solid/devices/backends/udisks2/udisksdevice.cpp 5283c2a
> src/solid/devices/backends/udisks2/udisksmanager.cpp 1e149c2
> src/solid/devices/backends/udisks2/udisksstorageaccess.cpp 1bd6acf
>
> Diff: https://git.reviewboard.kde.org/r/129277/diff/
>
>
> Testing
> -------
>
> Compiles, mounting works.
>
>
> Thanks,
>
> Gleb Popov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20161028/3952e479/attachment.html>
More information about the Kde-hardware-devel
mailing list