[Kde-hardware-devel] Review Request 125435: Fix updating brightness while animation is still running

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125435/
-----------------------------------------------------------

(Updated Sept. 28, 2015, 8:34 a.m.)


Status
------

This change has been discarded.


Review request for Solid and Kai Uwe Broulik.


Repository: powerdevil


Description
-------

If pressing the brightness shortcuts while the animation is still running (eg. when quickly pressing the key), it will simply ignore it. This results on my laptop (ThinkPad X220) to just react to second keypress in this case.

m_cachedBrightnessMap is updated when animation finishes. Another fix would be to update it when animation starts.

This is a followup fix for https://git.reviewboard.kde.org/r/125156/


Diffs
-----

  daemon/backends/upower/powerdevilupowerbackend.cpp ff21f4e 

Diff: https://git.reviewboard.kde.org/r/125435/diff/


Testing
-------

Brightness shortcut works correctly now, even when quickly pressing the shortcut.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150928/7226d615/attachment.html>