[Kde-hardware-devel] Review Request 125248: Display name of process which blocks umount / eject

[Igor Poboiko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125248/
-----------------------------------------------------------

(Updated Oct. 17, 2015, 7:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Solid.


Changes
-------

Submitted with commit d64719de4bf824b40cfe43965f09f8ac74605072 by Igor Poboiko to branch master.


Repository: plasma-workspace


Description
-------

An attempt to implement feature from [bug 96107](https://bugs.kde.org/show_bug.cgi?id=96107) (see summary).

On umount/eject error it runs "lsof" executable, gets PIDs of blocking processes and obtains names of processes via KSysGuard::Process machinery. Finally it appends obtained information to error message which is shown in tooltip of Device Notifier applet.


Diffs
-----

  dataengines/devicenotifications/CMakeLists.txt 3f7fd83 
  dataengines/devicenotifications/ksolidnotify.h a471d50 
  dataengines/devicenotifications/ksolidnotify.cpp 35d49d6 

Diff: https://git.reviewboard.kde.org/r/125248/diff/


Testing
-------

Tested unmount on busy device with several processes blocking it. Did not test eject, since I have no optical disc drive :(


File Attachments
----------------

Applet with error message
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/15/3b1b64fc-abff-4633-9dca-621388edf086__snapshot11.png


Thanks,

Igor Poboiko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20151017/c4f6ee4c/attachment.html>