[Kde-hardware-devel] Review Request 126146: [XRandRBrightness] Don't call for xrandr if it's not available

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126146/#review88726
-----------------------------------------------------------


+1
Functional patch looks fine, since the extension is not gonna mystically show up, one may wish to cache extension status validity in a tenary member (iff this constructor is called more often)

Can't tell about "unrelated changes policy" in the component ;-)

- Thomas Lübking


On Nov. 23, 2015, 4 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126146/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 4 nachm.)
> 
> 
> Review request for Solid and Thomas Lübking.
> 
> 
> Bugs: 352462
>     https://bugs.kde.org/show_bug.cgi?id=352462
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> Check whether the extension is there before calling into it.
> 
> Also cache calls to QX11Info::connection() if we're at it.
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/xrandrbrightness.cpp 0abcefe 
> 
> Diff: https://git.reviewboard.kde.org/r/126146/diff/
> 
> 
> Testing
> -------
> 
> Still works, didn't test without xrandr.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20151123/753bf5c6/attachment-0001.html>