[Kde-hardware-devel] Review Request 126138: Use absolute brightness value in conservative check when loading profile

Sebastian Kügler sebas at kde.org
Mon Nov 23 13:55:52 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126138/#review88723
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Nov. 22, 2015, 3:42 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126138/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2015, 3:42 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Bugs: 355687
>     https://bugs.kde.org/show_bug.cgi?id=355687
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> There's a check that ensures the brightness isn't ramped up when we switch to battery mode when the current brightness is lower. It compared the raw value (0 to whatever the drivers supports) to the stored (0 to 100) value.
> 
> 
> Diffs
> -----
> 
>   daemon/actions/bundled/brightnesscontrol.cpp d00d6ed 
>   daemon/actions/bundled/keyboardbrightnesscontrol.cpp a52dd75 
> 
> Diff: https://git.reviewboard.kde.org/r/126138/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20151123/ccc93351/attachment.html>


More information about the Kde-hardware-devel mailing list