[Kde-hardware-devel] Review Request 125182: Fix the brightness key being ignored during the animation

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125182/
-----------------------------------------------------------

(Updated Nov. 15, 2015, 6:51 p.m.)


Status
------

This change has been marked as submitted.


Review request for Solid and Kai Uwe Broulik.


Changes
-------

Submitted with commit 56e8b755c63a85568472f563fc65642e1de9f6da by Weng Xuetian to branch Plasma/5.4.


Repository: powerdevil


Description
-------

There is a check that update the m_cachedBrightness, which is not valid during the animation. Ignore if the brightness animation is running and calculate the new brightness level.

P.S. Why is this check there anyway? Is it useful or it's designed to workaround some hardware issue?


Diffs
-----

  daemon/backends/upower/powerdevilupowerbackend.cpp ff21f4e 

Diff: https://git.reviewboard.kde.org/r/125182/diff/


Testing
-------

Brightness can increase/decrease for every brightness key press.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20151115/386249fb/attachment.html>