[Kde-hardware-devel] Review Request 125182: Fix the brightness key being ignored during the animation

[Igor Poboiko]

> On Ноя. 15, 2015, 9:31 д.п., Igor Poboiko wrote:
> > Ship It!

Not a maintainer here. Running this patch for a month without side-effects. I believe this should end up in plasma 5.4!


- Igor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125182/#review88374
-----------------------------------------------------------


On Сен. 12, 2015, 1:45 д.п., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125182/
> -----------------------------------------------------------
> 
> (Updated Сен. 12, 2015, 1:45 д.п.)
> 
> 
> Review request for Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> There is a check that update the m_cachedBrightness, which is not valid during the animation. Ignore if the brightness animation is running and calculate the new brightness level.
> 
> P.S. Why is this check there anyway? Is it useful or it's designed to workaround some hardware issue?
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/powerdevilupowerbackend.cpp ff21f4e 
> 
> Diff: https://git.reviewboard.kde.org/r/125182/diff/
> 
> 
> Testing
> -------
> 
> Brightness can increase/decrease for every brightness key press.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20151115/f58a19a0/attachment.html>