[Kde-hardware-devel] Review Request 123860: Handle backend being deleted during GetConfigOperation

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123860/#review80657
-----------------------------------------------------------


+1

- Aleix Pol Gonzalez


On May 20, 2015, 2:36 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123860/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 2:36 p.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Bugs: 347626
>     http://bugs.kde.org/show_bug.cgi?id=347626
> 
> 
> Repository: libkscreen
> 
> 
> Description
> -------
> 
> GetConfigOperation stores a raw pointer to the backend in a property of
> the QDBusPendingCallWatcher
> 
> BackendManager owns this backend and can delete it at will if it becomes
> invalidated, leaving a dangling pointer in the watcher's property.
> 
> BUG: 347626
> 
> 
> Diffs
> -----
> 
>   src/getconfigoperation.cpp dac7a33edd87adb53d7b773acfe7f7dfe2229394 
> 
> Diff: https://git.reviewboard.kde.org/r/123860/diff/
> 
> 
> Testing
> -------
> 
> Never made the crash happen myself, but looking at the backtrace and the code it seems the a way it could have happened.
> 
> Tested behaviour as before still works.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150520/0daab9de/attachment.html>