[Kde-hardware-devel] Review Request 123678: Add Output::size and make it report correct size

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123678/
-----------------------------------------------------------

(Updated mai. 8, 2015, 10:26 a.m.)


Status
------

This change has been marked as submitted.


Review request for Solid.


Repository: libkscreen


Description
-------

We were making some assumptions in Output::geometry like for example
assuimg that the resolution of the currentMode was actually the output
size which is not always the case, like for example in a case we were
already covering of vertical transformed output.
    
In order to fix this proplerly we are adding a size property to Output
that backends and fill with whatever value they want and we use it to
create the QRrect with return in Output::geometry.
    
QScreen: Whatever QScreen::screenGeometry().size() returns
Fake: Added a test for singleOutput, the rest is all the same
XRandR11: Whatever size has currentMode
    
XRandR: Whatever size CRTC reports.
Note that crtc is the one in charge of applying transformations so it
always reports correct geometry, even on scaled or vertical/landscape
outputs.


Diffs
-----

  autotests/configs/multipleoutput.json 4e59b5f 
  autotests/configs/singleoutput.json bab8926 
  autotests/testconfigserializer.cpp 3e948b6 
  backends/fake/parser.cpp 43a5ec5 
  backends/qscreen/qscreenoutput.cpp 452ac3b 
  backends/xrandr/xrandroutput.h 32c5ddc 
  backends/xrandr/xrandroutput.cpp e1e5799 
  backends/xrandr1.1/xrandr11.cpp f6b5e46 
  src/configserializer.cpp 10739f2 
  src/output.h f71b798 
  src/output.cpp b47ad3d 

Diff: https://git.reviewboard.kde.org/r/123678/diff/


Testing
-------

Besides the autotests, I have checked with kscreen-console reports correct size with a 2x2 scaled output using all backends.
I have also used plasma and checked that now it is able to properly place dialogs.


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150508/e3838236/attachment.html>