[Kde-hardware-devel] Review Request 124388: Add ConsoleKit2 as a power backend

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124388/#review82730
-----------------------------------------------------------


Looks good to me.

Do you have commit access?


daemon/powerdevilpolicyagent.cpp (line 175)
<https://git.reviewboard.kde.org/r/124388/#comment57050>

    just pass a parent, rather than manual deletion in the destructor?
    OR
    wrap in QScopedPointer instead of QWeakPointer?
    
    otherwise you have potential leak if onSessionHandlerRegistered is called twice (not that will realistically happen)


- David Edmundson


On July 20, 2015, 2:04 p.m., Eric Koegel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124388/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 2:04 p.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> Internally, it uses the login1 interface with ConsoleKit2 since they share identical DBUS calls. It also changes the setupSystemdInhibition to setupSeatManagerInhibition so that the login1 and ConsoleKit2 inhibit calls to minimize code duplication.
> 
> This patch doesn't modify the build system to keep it small. A future patch can be added to use ConsoleKit2 on BSD systems as well.
> 
> ConsoleKit2's suspend/hibernate/inhibit DBUS API is documented at: http://consolekit2.github.io/ConsoleKit2/#Manager
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/powerdevilupowerbackend.h 3752977 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 5120d3e 
>   daemon/powerdevilpolicyagent.h ef41ad7 
>   daemon/powerdevilpolicyagent.cpp 9210a06 
> 
> Diff: https://git.reviewboard.kde.org/r/124388/diff/
> 
> 
> Testing
> -------
> 
> Built powerdevil with patch and pkla files on a Gentoo system with OpenRC. Before patch there was no suspend option, after there was and clicking it resulted in the system properly suspending.
> 
> 
> Thanks,
> 
> Eric Koegel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150720/ec3faeb3/attachment-0001.html>