[Kde-hardware-devel] Review Request 124318: Load DPMSAction only on xcb platform

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124318/
-----------------------------------------------------------

(Updated July 10, 2015, 9:27 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Solid.


Changes
-------

Submitted with commit cc89ab71b572473f84d94868fc82993073992a12 by Martin Gräßlin to branch master.


Repository: powerdevil


Description
-------

The DPMS action is implemented in a very x11 specific way calling into
xcb in the ctor and before supported can be checked. This causes a crash
on platforms != xcb.

In order to better support other platforms the action is marked as
xcb specific in the desktop file and the loading of Actions is adjusted
to only load Actions supported on the current platform.


Diffs
-----

  daemon/actions/dpms/powerdevildpmsaction.desktop 78c5d90fe62559f70431dd4bd6e195b765e0f477 
  daemon/powerdevilactionpool.cpp 0f0e69f0afe447935e6d17872f029c7c4ac33875 

Diff: https://git.reviewboard.kde.org/r/124318/diff/


Testing
-------

No longer crashes in a Plasma/Wayland session.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150710/7e0eddf2/attachment.html>