[Kde-hardware-devel] Review Request 122316: Fix powerdevil brightness calls breaking kded #2

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122316/#review75006
-----------------------------------------------------------

Ship it!


looks good to me


daemon/actions/bundled/brightnesscontrol.cpp
<https://git.reviewboard.kde.org/r/122316/#comment51938>

    remove or at least at some text with it


- David Edmundson


On Jan. 29, 2015, 9:06 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122316/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 9:06 p.m.)
> 
> 
> Review request for Solid and David Edmundson.
> 
> 
> Bugs: 337674
>     https://bugs.kde.org/show_bug.cgi?id=337674
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> - Query maximum value once and then just return the stored value, it's not like PowerDevil could really cope with it changing anyway
> - Query brightness value once and then just update it when udevqt tells us to
> - Don't care for the result when setting the brightness, just call it async
> 
> *adds refactoring this to be as async as possible to the 5.3 todo*
> 
> 
> Diffs
> -----
> 
>   daemon/actions/bundled/brightnesscontrol.h 5e569fd 
>   daemon/actions/bundled/brightnesscontrol.cpp 692a643 
>   daemon/backends/hal/powerdevilhalbackend.h ab04e53 
>   daemon/backends/hal/powerdevilhalbackend.cpp bec528a 
>   daemon/backends/upower/powerdevilupowerbackend.h 220289c 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 51a052a 
>   daemon/powerdevilbackendinterface.h 702b66b 
> 
> Diff: https://git.reviewboard.kde.org/r/122316/diff/
> 
> 
> Testing
> -------
> 
> I'm running on the helper now but I was never able to reproduce the problem.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150129/4e0d86de/attachment.html>