[Kde-hardware-devel] Review Request 122316: Fix powerdevil brightness calls breaking kded #2

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122316/
-----------------------------------------------------------

(Updated Jan. 29, 2015, 8:02 nachm.)


Review request for Solid and David Edmundson.


Changes
-------

Use m_cachedBrightnessMap to store the value which is now only queried once. Also fixes the OSD.


Bugs: 337674
    https://bugs.kde.org/show_bug.cgi?id=337674


Repository: powerdevil


Description (updated)
-------

- Query maximum value once and then just return the stored value, it's not like PowerDevil could really cope with it changing anyway
- Query brightness value once and then just update it when udevqt tells us to
- Don't care for the result when setting the brightness, just call it async

*adds refactoring this to be as async as possible to the 5.3 todo*


Diffs (updated)
-----

  daemon/backends/upower/powerdevilupowerbackend.h 220289c 
  daemon/backends/upower/powerdevilupowerbackend.cpp 51a052a 

Diff: https://git.reviewboard.kde.org/r/122316/diff/


Testing (updated)
-------

I'm running on the helper now but I was never able to reproduce the problem.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150129/1598e538/attachment.html>