[Kde-hardware-devel] Review Request 122283: Increase the preferred number of screen brightness steps to 20.

[Nikita Skovoroda]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122283/
-----------------------------------------------------------

Review request for Solid and Kai Uwe Broulik.


Repository: powerdevil


Description
-------

Currently (10 steps preferred):
http://oserv.org/tests/kde/powerdevil/brightness_after.php

After the patch (20 steps preferred):
http://oserv.org/tests/kde/powerdevil/brightness_after_2.php

See https://todo.kde.org/?controller=task&action=show&task_id=829 for reasoning.
See https://git.reviewboard.kde.org/r/119597/ for the steps logic explanation.


Diffs
-----

  daemon/powerdevilscreenbrightnesslogic.cpp 7948c67 

Diff: https://git.reviewboard.kde.org/r/122283/diff/


Testing
-------

Tested the new logic using a script to simulate different maxValue values (see the links above).
Did not test on the actual notebook, but it should work (current logic works), only the numbers are changed.


Thanks,

Nikita Skovoroda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150127/37805d6a/attachment.html>