[Kde-hardware-devel] Review Request 122236: Bring back activities support

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122236/#review74681
-----------------------------------------------------------


IMO, the UI for this was always wrong. I don't know whether changing it should be a part of this patch or not, this is up to the Solid people.

It should be tested whether stopping/starting/restarting kamd messes up anything.


daemon/powerdevilcore.cpp
<https://git.reviewboard.kde.org/r/122236/#comment51772>

    If this needs to have a 'default' activity, it should test against the nulluuid which is the single activity present when the service is not running.


- Ivan Čukić


On Jan. 24, 2015, 5:12 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122236/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2015, 5:12 p.m.)
> 
> 
> Review request for Solid and Ivan Čukić.
> 
> 
> Bugs: 340652
>     https://bugs.kde.org/show_bug.cgi?id=340652
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> This restores the ability to configure activity-specific power management settings. Also port to QTabWidget and QComboBox.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 27f162c 
>   daemon/CMakeLists.txt 454c681 
>   daemon/powerdevilcore.h 90a9fc6 
>   daemon/powerdevilcore.cpp 271173c 
>   kcmodule/activities/CMakeLists.txt a5129d6 
>   kcmodule/activities/activityWidget.ui ec22df2 
>   kcmodule/activities/activitypage.h 230f835 
>   kcmodule/activities/activitypage.cpp ed0ac45 
>   kcmodule/activities/activitywidget.cpp bfd0e1f 
> 
> Diff: https://git.reviewboard.kde.org/r/122236/diff/
> 
> 
> Testing
> -------
> 
> Compiles, configured it to suspend the session after 1 min in one activity and it did just that. Didn't do extensive testing.
> 
> 
> File Attachments
> ----------------
> 
> KCM in action
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/24/859af620-f1b1-4645-a7d5-86012c223e71__powerdevilactivities2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150124/84456cab/attachment.html>