[Kde-hardware-devel] Review Request 122048: Don't suspend when closing the lid and an external monitor is connected

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122048/
-----------------------------------------------------------

(Updated Jan. 24, 2015, 3:25 nachm.)


Review request for Solid, KDE Usability, Àlex Fiestas, and Daniel Vrátil.


Changes
-------

Expose whether the lid action will actually be triggered over dbus so battery monitor can display a hint (also Dan said he would've liked something like this for KScreen too). Lid action is now always explicit.

The hint does not say "currently will not suspend" because it's configured to never do that. There's a settings button in battery now to ease changing this setting.


Repository: powerdevil


Description
-------

Less sensational headline: Skip lid action when external monitor is connected.

This brings the KScreen killer feature in the 4.x times back. Now you can watch movies and safely close the lid again!

The confusing "Never prevent an action on lid close" is also moved to the main page since it only affects the lid action and is used nowhere else. I'm not happy with the wording but "inhibition" is a difficult thing to describe for the average user.


Diffs (updated)
-----

  CMakeLists.txt 27f162c 
  daemon/CMakeLists.txt 454c681 
  daemon/actions/bundled/handlebuttonevents.h 8ea23f6 
  daemon/actions/bundled/handlebuttonevents.cpp ac280f4 
  daemon/actions/bundled/handlebuttoneventsconfig.h a55bca7 
  daemon/actions/bundled/handlebuttoneventsconfig.cpp 92f0cef 
  daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.HandleButtonEvents.xml 68b2165 
  kcmodule/global/GeneralPage.cpp 5d9ff10 
  kcmodule/global/generalPage.ui 26204cb 

Diff: https://git.reviewboard.kde.org/r/122048/diff/


Testing
-------

Laptop only, monitor option on -> Suspend
Laptop only, monitor option off -> Suspend
TV connected, monitor option on -> No action
TV connected, monitor option off -> Suspend

PM enabled, inhibit option on -> Suspend
PM disabled, inhibit option on -> No suspend
PM enabled, inhibit option off -> Suspend
PM disabled, inhibit option off -> Suspend


File Attachments (updated)
----------------

Battery monitor hint
  https://git.reviewboard.kde.org/media/uploaded/files/2015/01/24/860157d4-5e21-45e7-8d0c-0f31e9d75428__externalmonitor1.png
New setting
  https://git.reviewboard.kde.org/media/uploaded/files/2015/01/24/7ea3d406-0f0a-491b-9539-9de93e42bb4b__powerdevilstuff2.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150124/6cc9dc6b/attachment.html>