[Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122151/#review74384
-----------------------------------------------------------


Could this be related to /r/122029? When KAuth failed to invoke the helper tool (because of the broken service file), the ExecJob got simply stuck. This was only fixed be rebuilding PowerDevil against the fixed KAuth...

- Daniel Vrátil


On Jan. 19, 2015, 4:46 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122151/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 4:46 p.m.)
> 
> 
> Review request for Solid and Kai Uwe Broulik.
> 
> 
> Bugs: 342597
>     https://bugs.kde.org/show_bug.cgi?id=342597
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> docs state the failure of exec shall be checked first.
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 51a052a 
> 
> Diff: https://git.reviewboard.kde.org/r/122151/diff/
> 
> 
> Testing
> -------
> 
> resolves the bug for me (i have the brightness control in the battery applet now)
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150120/f58cb4d5/attachment.html>