[Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic
Lukáš Tinkl
lukas at kde.org
Mon Jan 19 16:37:43 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122151/#review74344
-----------------------------------------------------------
Hmm I don't see how the order could affect the outcome, but if it fixes the problem for you, +1
- Lukáš Tinkl
On Led. 19, 2015, 4:46 odp., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122151/
> -----------------------------------------------------------
>
> (Updated Led. 19, 2015, 4:46 odp.)
>
>
> Review request for Solid and Kai Uwe Broulik.
>
>
> Bugs: 342597
> https://bugs.kde.org/show_bug.cgi?id=342597
>
>
> Repository: powerdevil
>
>
> Description
> -------
>
> docs state the failure of exec shall be checked first.
>
>
> Diffs
> -----
>
> daemon/backends/upower/powerdevilupowerbackend.cpp 51a052a
>
> Diff: https://git.reviewboard.kde.org/r/122151/diff/
>
>
> Testing
> -------
>
> resolves the bug for me (i have the brightness control in the battery applet now)
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150119/8a741da6/attachment.html>
More information about the Kde-hardware-devel
mailing list