[Kde-hardware-devel] Review Request 122130: Expose inhibitions over dbus

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122130/
-----------------------------------------------------------

(Updated Jan. 18, 2015, 9:06 nachm.)


Review request for Solid.


Changes
-------

Use QList<QPair<QString, QString>> instead of a flat QStringList
Make signal send along added and removed inhibitions to reduce DBus traffic


Repository: powerdevil


Description
-------

This adds a new "ListInhibitions" method and "InhibitionsChanged" signal to the org.kde.Solid.PowerManagement.PolicyAgent allowing others to know who has posted an inhibition.

Due to the complexity of DBus marshalling I chose to use a flat QStringList for it with the even indices being the application name and the odd ones the respective reason. It does not do any formatting (getting proper app names) or duplicate removal.


Diffs (updated)
-----

  daemon/kdedpowerdevil.h 137e6ca 
  daemon/kdedpowerdevil.cpp 4228741 
  daemon/org.kde.Solid.PowerManagement.PolicyAgent.xml a07dd73 
  daemon/powerdevilpolicyagent.h 08a3b54 
  daemon/powerdevilpolicyagent.cpp 7c7348d 

Diff: https://git.reviewboard.kde.org/r/122130/diff/


Testing
-------

Works, I can list the inhibitions using
qdbus --literal org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement/PolicyAgent org.kde.Solid.PowerManagement.PolicyAgent.ListInhibitions


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150118/f6850168/attachment.html>