[Kde-hardware-devel] Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement

[Daniel Vrátil]

> On Jan. 9, 2015, 12:25 p.m., Àlex Fiestas wrote:
> > Where do you plan to use this? We are not maintaining compatibility (so far) in our dbus apis, so why add this at all?

KScreen. For now we are listening to UPower, which IMO sucks and we should use PowerDevil instead (as it provides abstraction for alternative backends). This makes it just easier to monitor changes.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121915/#review73569
-----------------------------------------------------------


On Jan. 8, 2015, 1:04 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121915/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 1:04 p.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> There's no way to detect when lid has been closed other than listening to `changed` signal org.freedesktop.UPower and then polling the Powerdevil for new values. This patch adds a new signal to the PowerDevil interface to notify about the change and provide new value right away. Makes it much easier to use.
> 
> 
> Diffs
> -----
> 
>   daemon/org.kde.Solid.PowerManagement.xml 53f77e5 
>   daemon/powerdevilbackendinterface.h 702b66b 
>   daemon/powerdevilbackendinterface.cpp 6dd8c71 
>   daemon/powerdevilcore.h e255703 
>   daemon/powerdevilcore.cpp d51ab19 
> 
> Diff: https://git.reviewboard.kde.org/r/121915/diff/
> 
> 
> Testing
> -------
> 
> Tested with qdbus-monitor, signal is emitted when laptop lid is closed/opened.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150109/e6d3e042/attachment.html>