[Kde-hardware-devel] Review Request 121815: Cleanup BrightnessOSDWidget

Kai Uwe Broulik kde at privat.broulik.de
Sat Jan 3 21:33:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121815/
-----------------------------------------------------------

Review request for Solid.


Repository: powerdevil


Description
-------

It's no longer that fullblown widget it used to be bust just calls Plasma's OSD service via DBus. It might as well just be a namespace with a function inside, doesn't need to be a class.


Diffs
-----

  daemon/actions/bundled/brightnesscontrol.h 1c6f343 
  daemon/actions/bundled/brightnesscontrol.cpp 27355a0 
  daemon/actions/bundled/keyboardbrightnesscontrol.h 4dbc4cc 
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp de4c0a4 
  daemon/brightnessosdwidget.h 828b242 
  daemon/brightnessosdwidget.cpp f85e25c 

Diff: https://git.reviewboard.kde.org/r/121815/diff/


Testing
-------

Works like it did before.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150103/f4a26271/attachment.html>


More information about the Kde-hardware-devel mailing list