[Kde-hardware-devel] Review Request 122307: Fix powerdevil brightness calls breaking kded

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122307/
-----------------------------------------------------------

(Updated Feb. 16, 2015, 11:03 a.m.)


Status
------

This change has been discarded.


Review request for Solid.


Repository: powerdevil


Description
-------

Normal KJob->exec() spawns a new event loop in the same thread
which then processes other DBus events, which causes a reentrant
situation screwing with the QDBusContext

By running it in a new thread, we won't process other dbus messages as we block the main thread.

BUG: 337674


Diffs
-----

  daemon/backends/upower/powerdevilupowerbackend.h 220289c 
  daemon/backends/upower/powerdevilupowerbackend.cpp 51a052a 

Diff: https://git.reviewboard.kde.org/r/122307/diff/


Testing
-------

forced my comptuer to use the kauth system for brightness by bodging an if statement.

Confirmed I could change brightness using this code without anything breaking.

I'd prefer it if someone who had this issue could apply and test


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150216/8e76b4a3/attachment.html>