[Kde-hardware-devel] Review Request 122414: Port DPMS to XCB

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122414/
-----------------------------------------------------------

(Updated Feb. 9, 2015, 9:58 a.m.)


Status
------

This change has been marked as submitted.


Review request for Solid and Martin Gräßlin.


Repository: powerdevil


Description
-------

The documentation says that error events for void calls will be delivered to the event loop, what does that mean for us? Will Qt throw them away, or do we need to install an event handler for them similar to what the previous code did? Or use the checked variants?

Also adds some C++11 niceties and overall coding style cleanup. DPMS is now a required dependency for PowerDevil (is this a bad thing? given the thing was explicitly split out of the other actions).


Diffs
-----

  daemon/actions/dpms/powerdevildpmsaction.cpp 8586f94 
  CMakeLists.txt c9e9047 
  daemon/actions/CMakeLists.txt a1b70ca 
  daemon/actions/dpms/CMakeLists.txt 79c4062 
  daemon/actions/dpms/powerdevildpmsaction.h 31e11c6 

Diff: https://git.reviewboard.kde.org/r/122414/diff/


Testing
-------

Power button can turn off the screen, and after timeout turns off and properly wakes up again. Did not test inhibition handling.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150209/91a3e061/attachment.html>