[Kde-hardware-devel] Review Request 121995: Animate screen brightness change

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121995/
-----------------------------------------------------------

(Updated Feb. 7, 2015, 1:51 nachm.)


Review request for Solid.


Changes
-------

- Add config options for duration and threshold
- Don't mess with the helper, it's too fragile to be called repeatedly
- Cleanup a bit


Repository: powerdevil


Description
-------

Use a QPropertyAnimation to animate screen brightness changes, if supported by your configuration (enough steps available).


Diffs (updated)
-----

  PowerDevilSettings.kcfg 1bc7ce1 
  daemon/backends/upower/powerdevilupowerbackend.h efec91b 
  daemon/backends/upower/powerdevilupowerbackend.cpp c4fc546 

Diff: https://git.reviewboard.kde.org/r/121995/diff/


Testing
-------

Using Kernel 3.18 it now reports ~900 steps for my display and so when idle the screen dims smoothly, when changing brightness or using the brightness keys, the screen brightness changes smoothly with the OSD reporting the proper value and battery monitor sliders adjusting slightly delayed. Didn't test using the helper rather than XRandr.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150207/0a48782c/attachment.html>