[Kde-hardware-devel] Review Request 122414: Port DPMS to XCB

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122414/#review75361
-----------------------------------------------------------



daemon/actions/dpms/powerdevildpmsaction.cpp
<https://git.reviewboard.kde.org/r/122414/#comment52126>

    I doubt that the two xcb_flush are needed. The XFlush seem wrong to me, too, and might only have been needed for the XSetErrorHandler calls.
    
    Please try without the xcb_flushs.


- Martin Gräßlin


On Feb. 3, 2015, 10:18 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122414/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 10:18 p.m.)
> 
> 
> Review request for Solid and Martin Gräßlin.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> The documentation says that error events for void calls will be delivered to the event loop, what does that mean for us? Will Qt throw them away, or do we need to install an event handler for them similar to what the previous code did? Or use the checked variants?
> 
> Also adds some C++11 niceties and overall coding style cleanup. DPMS is now a required dependency for PowerDevil (is this a bad thing? given the thing was explicitly split out of the other actions).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c9e9047 
>   daemon/actions/CMakeLists.txt a1b70ca 
>   daemon/actions/dpms/CMakeLists.txt 79c4062 
>   daemon/actions/dpms/powerdevildpmsaction.h 31e11c6 
>   daemon/actions/dpms/powerdevildpmsaction.cpp 8586f94 
> 
> Diff: https://git.reviewboard.kde.org/r/122414/diff/
> 
> 
> Testing
> -------
> 
> Power button can turn off the screen, and after timeout turns off and properly wakes up again. Did not test inhibition handling.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150204/74368c84/attachment.html>