[Kde-hardware-devel] Review Request 107505: Show Battery Low notification on startup along with Broken Battery notifications so it doesn't appear before workspace is up

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107505/
-----------------------------------------------------------

(Updated Feb. 1, 2015, 12:20 nachm.)


Status
------

This change has been discarded.


Review request for Solid.


Repository: kde-workspace


Description
-------

I made PowerDevil show the battery low and critical notifications directly on startup so you cannot miss them. However, I complained about that DPMS profile warning and then added another notification that appears right on startup :P
Because of the nature of the notifications which are emitted in the onDeviceAdded part, it is emitted when PowerDevil comes up, leading to a similar ugly notification. This patch suppresses any notifications from onDeviceAdded until the checkBatteryStatus slot is fired, and then emits the notifications as needed.

CCBUG: 261890


Diffs
-----

  powerdevil/daemon/powerdevilcore.h 77c3f2f 
  powerdevil/daemon/powerdevilcore.cpp 2dcdbc6 

Diff: https://git.reviewboard.kde.org/r/107505/diff/


Testing
-------

Tested with AC unplugged, logged in, no notification, after 30 seconds in the workspace, I got a notification saying my battery is low.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150201/f6a15cd3/attachment.html>