[Kde-hardware-devel] Review Request 126390: [GCI] Fix some Clazy warnings
Imran Tatriev
itatriev at gmail.com
Wed Dec 16 20:49:08 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126390/
-----------------------------------------------------------
Review request for Bluedevil.
Repository: bluedevil
Description
-------
I've fixed some warnings, here they are:
- Passing non-trivial const types by value instead of const reference
- Unneeded heap allocation with QString
- Places, where QString::fooRef() should be used instead of QString::foo()
Diffs
-----
src/kded/receivefilejob.cpp 4a44e74
src/kio/bluetooth/kiobluetooth.cpp 569bf0f
src/sendfile/pages/selectdeviceandfilespage.cpp 3a091ae
src/wizard/wizardagent.cpp 277ec3b
Diff: https://git.reviewboard.kde.org/r/126390/diff/
Testing
-------
Thanks,
Imran Tatriev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20151216/dcfe9b52/attachment.html>
More information about the Kde-hardware-devel
mailing list