[Kde-hardware-devel] Review Request 126338: fixed Clazy warnings [-Wclazy-foreach] and [-Wclazy-detaching-temporary]

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126338/#review89432
-----------------------------------------------------------

Ship it!


Ship It!

- David Rosca


On Dec. 13, 2015, 9:58 p.m., Artur Puzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126338/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2015, 9:58 p.m.)
> 
> 
> Review request for Bluedevil and David Rosca.
> 
> 
> Repository: bluez-qt
> 
> 
> Description
> -------
> 
> fixed Clazy warning: Missing reference in foreach with non trivial type (DevicePtr) [-Wclazy-foreach]
> fixed warning: Don't call QList::first() on temporary [-Wclazy-detaching-temporary]
> 
> 
> Diffs
> -----
> 
>   autotests/devicetest.cpp 59b1ef8 
>   src/devicesmodel.cpp 66fc262 
>   src/manager_p.cpp 0e59570 
>   tests/devicereceiver.cpp c182e93 
> 
> Diff: https://git.reviewboard.kde.org/r/126338/diff/
> 
> 
> Testing
> -------
> 
> Automated tests passed.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20151213/15aa810f/attachment.html>