[Kde-hardware-devel] Review Request 124730: [solid-device-automounter] Port to KF5

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124730/
-----------------------------------------------------------

Review request for Plasma, Solid and Torrie Fischer.


Repository: plasma-desktop


Description
-------

This is a straight port of the solid-device-automounter from kde-runtime that was somehow lost to plasma-desktop. I didn't do git graft magic (can this be done later? ie. import kde-runtime folder here to there and then apply a diff on top?).


Diffs
-----

  CMakeLists.txt 4717780 
  solid-device-automounter/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/COPYING PRE-CREATION 
  solid-device-automounter/SETTINGS PRE-CREATION 
  solid-device-automounter/kcm/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.h PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp PRE-CREATION 
  solid-device-automounter/kcm/DeviceAutomounterKCM.ui PRE-CREATION 
  solid-device-automounter/kcm/DeviceModel.h PRE-CREATION 
  solid-device-automounter/kcm/DeviceModel.cpp PRE-CREATION 
  solid-device-automounter/kcm/LayoutSettings.kcfg PRE-CREATION 
  solid-device-automounter/kcm/LayoutSettings.kcfgc PRE-CREATION 
  solid-device-automounter/kcm/Messages.sh PRE-CREATION 
  solid-device-automounter/kcm/device_automounter_kcm.desktop PRE-CREATION 
  solid-device-automounter/kded/CMakeLists.txt PRE-CREATION 
  solid-device-automounter/kded/DeviceAutomounter.h PRE-CREATION 
  solid-device-automounter/kded/DeviceAutomounter.cpp PRE-CREATION 
  solid-device-automounter/kded/device_automounter.desktop PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettings.h PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettings.cpp PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettingsBase.kcfg PRE-CREATION 
  solid-device-automounter/lib/AutomounterSettingsBase.kcfgc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124730/diff/


Testing
-------

Seems to work, translations are probably broken.
Told it to auto mount all the things, did that. Told it to mount just one thing automatically, did that. Somehow the list of non-attached devices grows even when I re-attach the same device.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150813/60fc8aa8/attachment.html>