[Kde-hardware-devel] Review Request 123418: Add X11 guards

[Nerdopolis Turfwalker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123418/#review79234
-----------------------------------------------------------

Ship it!


kded5 no longer crashes due to powerdevel, and it appears to still work.

- Nerdopolis Turfwalker


On April 18, 2015, 4:34 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123418/
> -----------------------------------------------------------
> 
> (Updated April 18, 2015, 4:34 p.m.)
> 
> 
> Review request for Solid, Martin Gräßlin and Nerdopolis Turfwalker.
> 
> 
> Bugs: 346341
>     https://bugs.kde.org/show_bug.cgi?id=346341
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> Improve X11 guards by correcting compile-time checks and adding runtime checks; also don't constantly query QX11Info.
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/xrandrbrightness.h 67d44a8 
>   daemon/backends/upower/xrandrbrightness.cpp f1cd5a5 
>   daemon/kwinkscreenhelpereffect.h 4d0a163 
>   daemon/kwinkscreenhelpereffect.cpp dec5d65 
> 
> Diff: https://git.reviewboard.kde.org/r/123418/diff/
> 
> 
> Testing
> -------
> 
> Compiles both with and without HAVE_XCB but I don't have a Wayland setup.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150420/61cd83c9/attachment.html>