[Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

[Lamarque Souza]

> On April 5, 2015, 5:12 p.m., Lamarque Souza wrote:
> > daemon/backends/upower/ddchelper.h, line 26
> > <https://git.reviewboard.kde.org/r/123262/diff/1/?file=360124#file360124line26>
> >
> >     Please do not use "using" inside a header file. That can lead to wierd compiling errors.
> 
> Kai Uwe Broulik wrote:
>     This is done in the backlighthelper as well and without it the KAuth helper does not work at all for some reason.

Even if you prefix ActionReply with KAuth namespace (KAuth::ActionReply) in this header and copy "using namespace KAuth;" to all .cpp files that include this file? That should the correct way of using... "using" hehe.


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123262/#review78529
-----------------------------------------------------------


On April 5, 2015, 5:31 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123262/
> -----------------------------------------------------------
> 
> (Updated April 5, 2015, 5:31 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> This allows PowerDevil to use the ddccontrol utility to manipulate brightness of external monitors through Display Data Channel.
> 
> It becomes the last link in the fallback chain; it first tries XRandR, then it tries the sysfs helper, and if all that fails it tries to use the ddccontrol utility.
> 
> dcccontrol unfortunately doesn't have machine-readable output so I have to take apart its probing output to get the device name and id of the backlight controls. Also it is pretty slow both initializing (kded startup, the helper saves the values and writes directly to the address returned by the initial probing) and setting brightness (that one doesn't block but it can take seconds until your monitor actually changes brightness)
> 
> 
> Diffs
> -----
> 
>   daemon/BackendConfig.cmake 295a8a2 
>   daemon/backends/upower/ddc_helper_actions.actions PRE-CREATION 
>   daemon/backends/upower/ddchelper.h PRE-CREATION 
>   daemon/backends/upower/ddchelper.cpp PRE-CREATION 
>   daemon/backends/upower/powerdevilupowerbackend.h 1c4dd59 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 87b9cc7 
> 
> Diff: https://git.reviewboard.kde.org/r/123262/diff/
> 
> 
> Testing
> -------
> 
> It's working pretty nicely, I can adjust brightness of my desktop monitor through battery monitor and have it automatically dimmed after a timeout.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150405/3af23d23/attachment.html>