[Kde-hardware-devel] Review Request 120879: Check country name existence country name map instead of filter by length in mobile provider

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120879/
-----------------------------------------------------------

(Updated Oct. 30, 2014, 4:29 a.m.)


Status
------

This change has been marked as submitted.


Review request for Solid.


Repository: plasma-nm


Description
-------

In some translation, for example, Chinese,  quite a lot of tranlated country name are length-2 string, which make provider list empty in those case.

Check the country name existence in m_Countries IMHO is better.


Diffs
-----

  libs/editor/mobileproviders.cpp df1f7ad 

Diff: https://git.reviewboard.kde.org/r/120879/diff/


Testing
-------

using zh_CN and select China, provider name listed.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141030/7d297bb5/attachment-0001.html>