[Kde-hardware-devel] Review Request 120823: Fix KScreen when disconnecting a screen

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120823/#review69239
-----------------------------------------------------------


I have to look back at the history to remember all this (I do remember I did good commits explaining everything) in order to properly review this patch. Will do so today!

- Àlex Fiestas


On oct. 27, 2014, 5:09 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120823/
> -----------------------------------------------------------
> 
> (Updated oct. 27, 2014, 5:09 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Dan Vrátil.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> -------
> 
> So far, XRandRConfig::applyKScreenConfig was using the previous screen position which wouldn't agree with the screen computed by screenSize(config) (xrandrconfig.cpp:166). This would try to remove the screen even if it was not needed.
> 
> This was a problem because in my system where I had 1920x1080+1280+0 and 1280x800+0+280. If I removed the first one, then both were removed and then the small one added back in, then Qt will collapse because we were requesting 1280x800+0+0, while it was in 1280x800+0+280.
> 
> 
> Diffs
> -----
> 
>   backends/xrandr/xrandrconfig.cpp 3b37add 
> 
> Diff: https://git.reviewboard.kde.org/r/120823/diff/
> 
> 
> Testing
> -------
> 
> We managed to reproduce the bug consistently in David and my system up until we figured out why Qt was crashing (which will receive bug reports and patches anyway).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141028/be249596/attachment.html>