[Kde-hardware-devel] Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120526/#review68180
-----------------------------------------------------------


Looks good, the qDebug though has to be ported to QCDebug so we can avoid spamming kded process with our logs.

- Àlex Fiestas


On oct. 8, 2014, 7:42 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120526/
> -----------------------------------------------------------
> 
> (Updated oct. 8, 2014, 7:42 p.m.)
> 
> 
> Review request for Plasma, Solid, Àlex Fiestas, and Lukáš Tinkl.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> there's still some usage left in the kcm subdir, i'll look into that one also soon. also, will open a review to convert to qCDebug
> 
> 
> Diffs
> -----
> 
>   kcmodule/common/actioneditwidget.h e73fb44 
>   kcmodule/common/actioneditwidget.cpp d6c5e6c 
>   kcmodule/global/CMakeLists.txt 77bbd07 
>   kcmodule/global/GeneralPage.cpp cdad263 
>   kcmodule/global/generalPage.ui 2b5585c 
>   kcmodule/profiles/CMakeLists.txt 1a13bb3 
>   daemon/powerdevilcore.h 36f4004 
>   daemon/powerdevilcore.cpp b178cdf 
>   daemon/powerdevilkeyboardbrightnesslogic.cpp 7709fda 
>   daemon/powerdevilpolicyagent.h 41e8e6b 
>   daemon/powerdevilpolicyagent.cpp d217e92 
>   daemon/powerdevilprofilegenerator.cpp 67ef77c 
>   daemon/powerdevilscreenbrightnesslogic.cpp 8da7dff 
>   kcmodule/common/CMakeLists.txt 9319067 
>   kcmodule/common/ErrorOverlay.h a2249c0 
>   kcmodule/common/ErrorOverlay.cpp adad48f 
>   daemon/actions/bundled/runscriptconfig.cpp dc705af 
>   daemon/actions/bundled/suspendsession.cpp 6704134 
>   daemon/actions/bundled/suspendsessionconfig.h cf94b87 
>   daemon/actions/bundled/suspendsessionconfig.cpp 95df0e0 
>   daemon/actions/dpms/CMakeLists.txt c53f0aa 
>   daemon/actions/dpms/powerdevildpmsaction.cpp be079f4 
>   daemon/actions/dpms/powerdevildpmsactionconfig.h b6271ff 
>   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 823a9bf 
>   daemon/backends/hal/powerdevilhalbackend.h b282634 
>   daemon/backends/hal/powerdevilhalbackend.cpp 69e8ce0 
>   daemon/backends/upower/login1suspendjob.cpp ce63c2e 
>   daemon/backends/upower/powerdevilupowerbackend.h beb12aa 
>   daemon/backends/upower/powerdevilupowerbackend.cpp f0fb73c 
>   daemon/backends/upower/upowersuspendjob.cpp 933de17 
>   daemon/kdedpowerdevil.cpp 5d6b91c 
>   daemon/powerdevilaction.cpp f16394c 
>   daemon/powerdevilactionpool.h 93ade44 
>   daemon/powerdevilactionpool.cpp 970aa18 
>   daemon/powerdevilbackendinterface.h abf7618 
>   daemon/powerdevilbackendinterface.cpp f157a73 
>   daemon/powerdevilbackendloader.cpp 8259a13 
>   daemon/BackendConfig.cmake 54094e0 
>   daemon/CMakeLists.txt 544cffe 
>   daemon/actions/bundled/CMakeLists.txt 4632267 
>   daemon/actions/bundled/brightnesscontrol.cpp 34dc578 
>   daemon/actions/bundled/brightnesscontrolconfig.h 33120c3 
>   daemon/actions/bundled/dimdisplay.cpp fc26585 
>   daemon/actions/bundled/dimdisplayconfig.h 14b7879 
>   daemon/actions/bundled/dimdisplayconfig.cpp 1b880ce 
>   daemon/actions/bundled/handlebuttonevents.cpp 6072507 
>   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 7b1dfdc 
>   daemon/actions/bundled/keyboardbrightnesscontrolconfig.h c546fd7 
>   daemon/actions/bundled/runscriptconfig.h 7ad61cf 
> 
> Diff: https://git.reviewboard.kde.org/r/120526/diff/
> 
> 
> Testing
> -------
> 
> builds, kded is succesfully initialized, reducing/increasing brightness work
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141009/490844f8/attachment.html>