[Kde-hardware-devel] Review Request 120372: Add disconnect/re-connect in tray menu and fix wrong status when adapter changes

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120372/#review68175
-----------------------------------------------------------

Ship it!


Ship it but please forward this to the frameworks branch (replacing QAction with KACtion, do not add kde4libssupport dependencies).

Thanks!

- Àlex Fiestas


On set. 25, 2014, 6:57 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120372/
> -----------------------------------------------------------
> 
> (Updated set. 25, 2014, 6:57 p.m.)
> 
> 
> Review request for Bluedevil and Àlex Fiestas.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> 1. Add "re-connect" and "disconnect" actions to device just like kcm
> 2. Disconnect all signals for adapter and devices in offlineMode in order to avoid multiple connection
> 3. use poweredChanged to populate the adapter status change and remove some redundant calls to regenerateConnectedDevice() and regenerateDeviceEntries(). Before this change, when I suspend the laptop, bluetooth device automatically go powered off (an unrelated issue), but the status might become "No adaptors found", while it should be "Turn bluetooth On". This is because adapterChanged() will only do update inside offlineMode(), and regenerateDeviceEntries() is not called in this case. To make it more consistent, all state populate function call are removed from onlineMode and moved to the function call onlineMode() and offlineMode().
> 
> 
> Diffs
> -----
> 
>   src/monolithic/monolithic.h 2d6790a 
>   src/monolithic/monolithic.cpp 016f930 
> 
> Diff: https://git.reviewboard.kde.org/r/120372/diff/
> 
> 
> Testing
> -------
> 
> Re-connect and disconnect works, and menu and tray is updated correctly when device get connected and disconnected.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141009/2e543ab9/attachment.html>