[Kde-hardware-devel] Review Request 120823: Fix KScreen when disconnecting a screen

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120823/
-----------------------------------------------------------

(Updated nov. 23, 2014, 5:35 p.m.)


Status
------

This change has been discarded.


Review request for Solid, Àlex Fiestas and Daniel Vrátil.


Repository: libkscreen


Description
-------

So far, XRandRConfig::applyKScreenConfig was using the previous screen position which wouldn't agree with the screen computed by screenSize(config) (xrandrconfig.cpp:166). This would try to remove the screen even if it was not needed.

This was a problem because in my system where I had 1920x1080+1280+0 and 1280x800+0+280. If I removed the first one, then both were removed and then the small one added back in, then Qt will collapse because we were requesting 1280x800+0+0, while it was in 1280x800+0+280.


Diffs
-----

  backends/xrandr/xrandrconfig.cpp 3b37add 

Diff: https://git.reviewboard.kde.org/r/120823/diff/


Testing
-------

We managed to reproduce the bug consistently in David and my system up until we figured out why Qt was crashing (which will receive bug reports and patches anyway).


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141123/582babfc/attachment.html>