[Kde-hardware-devel] Review Request 121188: Use a proper ToolButton for the refresh button

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121188/#review70702
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Grulich


On Lis. 20, 2014, 6:25 odp., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121188/
> -----------------------------------------------------------
> 
> (Updated Lis. 20, 2014, 6:25 odp.)
> 
> 
> Review request for Solid and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> This gives the button proper hover and touch feedback, also:
>  - Use an Animator which runs directly on the GPU and saves CPU cycles
>  - Clean up a bit (anchors.centerIn for instance)
> 
> Side note: units.gridUnit is guaranteed to be divisible by 2, so no need to round that
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/Header.qml a63fa8d60d9857c489d6a01e66536ca5c0bbe5dc 
> 
> Diff: https://git.reviewboard.kde.org/r/121188/diff/
> 
> 
> Testing
> -------
> 
> Looks like it did before.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141120/4919ce15/attachment.html>