[Kde-hardware-devel] Review Request 120974: Fix installation of libbluedevil on Debian/Ubuntu multiarch

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120974/#review70195
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Nov. 4, 2014, 12:06 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120974/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 12:06 p.m.)
> 
> 
> Review request for Solid and Àlex Fiestas.
> 
> 
> Repository: libbluedevil
> 
> 
> Description
> -------
> 
> Use GNUInstallDirs instead of creating a custom LIB_INSTALL_DIR
> 
> Without this patch, things install into lib64 on my Debian multiarch
> system, with this patch, it gets correctly put into lib/x86_64-linux-gnu
> As a result, we can drop LIB_SUFFIX.
> 
> This patch is needed so bluedevil can find its lib on my system (and
> supposedly other Debian and Ubuntu variants that use multiarch).
> 
> I had discussed this problem with Alex, he wanted to avoid a dependency on KDEInstallDirs. GNUInstallDirs is part of cmake proper, so no additional dependencies with this.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f494fe2 
> 
> Diff: https://git.reviewboard.kde.org/r/120974/diff/
> 
> 
> Testing
> -------
> 
> Did a clean install, bluedevil now finds its lib where it previously wouldn't.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141110/971e0e72/attachment.html>