[Kde-hardware-devel] Review Request 119834: Don't report gphoto devices that are child of gphoto devices

Lukáš Tinkl lukas at kde.org
Sun Nov 9 17:51:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119834/#review70120
-----------------------------------------------------------

Ship it!


Sorry, somehow this got buried in my inbox.

- Lukáš Tinkl


On Srp. 19, 2014, 12:14 dop., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119834/
> -----------------------------------------------------------
> 
> (Updated Srp. 19, 2014, 12:14 dop.)
> 
> 
> Review request for Solid, Àlex Fiestas and Lukáš Tinkl.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> When pluggin in my camera i get two cameras in the device notifier, seems udev returns twice see http://paste.kde.org/prbu43pgo and http://paste.kde.org/poh8hutaj
> 
> So I decided that it made no sense to report gphoto devices that are child of another gphoto device.
> 
> This may be a totally broken assumption. Other ways to fix the issue accepted.
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/udev/udevmanager.cpp 1f6369f 
> 
> Diff: https://git.reviewboard.kde.org/r/119834/diff/
> 
> 
> Testing
> -------
> 
> Now my camera shows up only once.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141109/5831cb8b/attachment.html>


More information about the Kde-hardware-devel mailing list