[Kde-hardware-devel] Review Request 120990: Ensure the application doesn't crash if a null mode is being passed to qDebug()

Sebastian Kügler sebas at kde.org
Wed Nov 5 09:44:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120990/#review69877
-----------------------------------------------------------

Ship it!


Ship It!


src/mode.cpp
<https://git.reviewboard.kde.org/r/120990/#comment48904>

    parentheses, please.


- Sebastian Kügler


On Nov. 4, 2014, 5:06 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120990/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 5:06 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Dan Vrátil.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> -------
> 
> Checks the mode being print, if it's null.
> 
> 
> Diffs
> -----
> 
>   src/mode.cpp 2af466d 
> 
> Diff: https://git.reviewboard.kde.org/r/120990/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141105/47af2a4b/attachment.html>


More information about the Kde-hardware-devel mailing list