[Kde-hardware-devel] Review Request 118288: Disable debugging by default for plasma-nm

[Sebastian Kügler]

> On May 24, 2014, 2:33 a.m., Lamarque Souza wrote:
> > libs/models/networkmodel.cpp, line 35
> > <https://git.reviewboard.kde.org/r/118288/diff/1/?file=274648#file274648line35>
> >
> >     Unless Jan Grulich has something against this change I am ok with it.
> 
> Jan Grulich wrote:
>     Also fine with me, I'm just wondering if is possible to enable this debug for users later, like before with kdebugdialog, so they don't have to compile it to have enabled debug.

This can be controlled at runtime, so we should be fine: http://qt-project.org/doc/qt-5/qloggingcategory.html#logging-rules


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118288/#review58384
-----------------------------------------------------------


On May 23, 2014, 7:12 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118288/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 7:12 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Disable debugging by default for plasma-nm
> 
> When starting plasmashell, we get way too much output in the console,
> making it hard to spot actual problems.
> 
> 
> Diffs
> -----
> 
>   libs/models/networkmodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118288/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140526/2b12a49f/attachment.html>