[Kde-hardware-devel] Review Request 118286: Port libnm-qt to categorized logging

[Sebastian Kügler]

> On May 23, 2014, 7:09 p.m., Lamarque Souza wrote:
> > src/settings/vpnsetting.cpp, line 128
> > <https://git.reviewboard.kde.org/r/118286/diff/1/?file=274408#file274408line128>
> >
> >     Hmmm, this debug message should have never been commited uncommented (it prints secrets to the log). When I get home [1] I will push a commit to comment this line. Or you can comment it in your patch and push it for me :-)
> >     
> >     [1] I do not have access to KDE's git repo from my work.

I've commented it. Thanks for the quick review.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118286/#review58376
-----------------------------------------------------------


On May 24, 2014, 12:15 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118286/
> -----------------------------------------------------------
> 
> (Updated May 24, 2014, 12:15 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: libnm-qt
> 
> 
> Description
> -------
> 
> Port to categorized logging
> 
> This patch ports the usage of qDebug to the new categorized logging.
> 
> I'm disabling logging by default, it can be overwritten with an env var
> or in a config file. For most users, this kind of low-level debug
> information hides more problems than it shows.
> 
> libnm-qt is one of the most chatty codebases, and it hides a lot of 
> problems in other parts of the whole plasmashell. We're trying to get
> it to be more silent by default, so we can better spot real problems.
> 
> See also  http://community.kde.org/Frameworks/Porting_To_qCDebug
> 
> 
> Diffs
> -----
> 
>   examples/createconnection/main.cpp ab14d6538a486231afbed408f75f1c33b3dfff05 
>   examples/main.cpp d239406341d929ca58cdda443dda2b41e7d1c670 
>   src/accesspoint.cpp 5e78b9b69edaf62d948619d11a22657a0877e6c0 
>   src/connection.cpp 438d4332ec6ac3ac620fdf93ae74c1aa77df3f07 
>   src/device.cpp f1f9ab5b80c751a66af409feec8e177de741f17e 
>   src/manager.cpp 1e04627d6513cc3c771361bfd8b5710cbf851a8d 
>   src/nmdebug.h c701eba412d69e97243c651ea2e8fe03a3343f0d 
>   src/secretagent.cpp cf9be839beb27e001ea7134df6f38b20e6c6730d 
>   src/settings.cpp 11c75d06a24ca3e46c4235858208b1b31c7218b5 
>   src/settings/template.cpp 1e3cda56174d96ed576e292a36f716d27f4df462 
>   src/settings/vpnsetting.cpp ae7f38594aff66411672476f43d0295ad0b94015 
>   src/wimaxdevice.cpp 73dd24d793b504912dff5479149d7ce858649883 
>   src/wirelessdevice.cpp 67931c127259ecb2905268688f861d5702d8edc4 
> 
> Diff: https://git.reviewboard.kde.org/r/118286/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140524/1f831459/attachment-0001.html>