[Kde-hardware-devel] Review Request 117939: Port monolithic from KDELibs4Support

David Rosca nowrep at gmail.com
Mon May 5 12:06:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117939/
-----------------------------------------------------------

(Updated May 5, 2014, 12:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for Bluedevil and Àlex Fiestas.


Repository: bluedevil


Description
-------

This patch removes all usage of KDELibs4Support in monolithic (src/monolithic).
All string literals are also wrapped in QLatin1String/QStringLiteral.
Removed unused m_interfaceMap and EntryInfo struct.

Use QMenu::addSection instead of KMenu::addTitle.
Use QCommandLineParser instead of KCmdArgs. It does not support --license and --author options now.


Diffs
-----

  src/monolithic/CMakeLists.txt 5822e27 
  src/monolithic/main.cpp 312d8de 
  src/monolithic/monolithic.h 2d6790a 
  src/monolithic/monolithic.cpp 980531a 

Diff: https://git.reviewboard.kde.org/r/117939/diff/


Testing
-------


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140505/d3b58ab3/attachment.html>


More information about the Kde-hardware-devel mailing list