[Kde-hardware-devel] Review Request 117939: Port monolithic from KDELibs4Support

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117939/#review57276
-----------------------------------------------------------

Ship it!


Another good patch, good to go!

- Àlex Fiestas


On May 2, 2014, 1:45 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117939/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 1:45 p.m.)
> 
> 
> Review request for Bluedevil and Àlex Fiestas.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> This patch removes all usage of KDELibs4Support in monolithic (src/monolithic).
> All string literals are also wrapped in QLatin1String/QStringLiteral.
> Removed unused m_interfaceMap and EntryInfo struct.
> 
> Use QMenu::addSection instead of KMenu::addTitle.
> Use QCommandLineParser instead of KCmdArgs. It does not support --license and --author options now.
> 
> 
> Diffs
> -----
> 
>   src/monolithic/CMakeLists.txt 5822e27 
>   src/monolithic/main.cpp 312d8de 
>   src/monolithic/monolithic.h 2d6790a 
>   src/monolithic/monolithic.cpp 980531a 
> 
> Diff: https://git.reviewboard.kde.org/r/117939/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140504/dd54682d/attachment.html>